Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize styling of menu button table column #2247

Closed
mollykreis opened this issue Jul 9, 2024 · 2 comments · Fixed by #2309
Closed

Finalize styling of menu button table column #2247

mollykreis opened this issue Jul 9, 2024 · 2 comments · Fixed by #2309
Assignees
Labels
bug Something isn't working

Comments

@mollykreis
Copy link
Contributor

mollykreis commented Jul 9, 2024

🐛 Bug Report

There are some changes that have been proposed to the styling of the menu button column that are not being addressed in the initial submission (#2204). Specifically, the following changes have been proposed by Brandon and Fred:

  • Make the button the standard height (32px) rather than the slim control height
  • Change the left/right padding within the button to 8px rather than 16px Conceding that the 16px padding is sufficient given that there isn't a supported way to update the padding.
  • Change the font of the button to no longer be bold so that the text doesn't stand out from the rest of the table Leaving the font bold because this is the convention within nimble to show that text is interactable (such as in a ghost button)

These changes, however, are not easily achieved using supported styling on the button. We also need to evaluate how a 32px button looks with hover and focus states of the row/cell in the table.

We should also look into creating a focus theme matrix for the column to have chromatic testing for the focus state of the button within the table.

💻 Repro or Code Sample

🤔 Expected Behavior

The goal is to make the menu button look more like a select within the table.

😯 Current Behavior

💁 Possible Solution

🔦 Context

🌍 Your Environment

  • OS & Device: [e.g. MacOS, iOS, Windows, Linux] on [iPhone 7, PC]
  • Browser [e.g. Microsoft Edge, Google Chrome, Apple Safari, Mozilla FireFox]
  • Version [e.g. 1.8.0]
@mollykreis mollykreis added bug Something isn't working triage New issue that needs to be reviewed labels Jul 9, 2024
@mollykreis mollykreis mentioned this issue Jul 9, 2024
1 task
@m-akinc m-akinc removed the triage New issue that needs to be reviewed label Jul 9, 2024
@mollykreis
Copy link
Contributor Author

I chatted with @fredvisser, and we've come to the decision that the only change we'll make at this time to the styling of the menu button is to make it the default height of 32px rather than as-is (24px).

@rajsite
Copy link
Member

rajsite commented Jul 30, 2024

@mollykreis for future reference can you capture on the struck out lines in the description why we aren't pursing the padding change and non-bold text?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

3 participants