Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lighthouse performance metric assert dropped from 0.9 to 0.8 #2281

Open
rajsite opened this issue Jul 17, 2024 · 0 comments
Open

Lighthouse performance metric assert dropped from 0.9 to 0.8 #2281

rajsite opened this issue Jul 17, 2024 · 0 comments

Comments

@rajsite
Copy link
Member

rajsite commented Jul 17, 2024

🧹 Tech Debt

Recent builds have been failing the lighthouse performance assertions for the Angular example-client-app. In a commit pushed to main the performance threshold was lowered to 0.8.

We should consider how to resolve the performance issue, some ideas:

  • The metric is useful and we should listen. Modify the examples such that they have fewer elements by default (buttons to generate rows, combox options, etc) or that the perf warnings about unused JS are addressed
  • We decide the metric is not useful and decide what we want to get out of the lighthouse review for the example angular app. Maybe we turn-off performance tracking (which might be unfavorable for early detection of drastic changes)
@rajsite rajsite added tech debt triage New issue that needs to be reviewed labels Jul 17, 2024
@m-akinc m-akinc removed the triage New issue that needs to be reviewed label Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Defined/Ready to Pickup
Development

No branches or pull requests

2 participants