Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nimble-breadcrumb padding differs from visual design #2297

Closed
fredvisser opened this issue Jul 22, 2024 · 2 comments
Closed

nimble-breadcrumb padding differs from visual design #2297

fredvisser opened this issue Jul 22, 2024 · 2 comments
Labels
bug Something isn't working visual design Visual design work item

Comments

@fredvisser
Copy link
Contributor

fredvisser commented Jul 22, 2024

🐛 Bug Report

The nimble-breadcrumb doesn't have padding on the left side, unlike the design. This impacts the sl-breadcrumb implementation.

@NIbokeefe - FYI - this issue may be contributing to feedback that the menu-button and prominent breadcrumb item don't match well. Let's also use this to confirm the colors are as designed.

🤔 Expected Behavior

Screenshot 2024-07-22 at 3 09 31 PM

😯 Current Behavior

Screenshot 2024-07-22 at 3 07 20 PM
@fredvisser fredvisser added bug Something isn't working triage New issue that needs to be reviewed labels Jul 22, 2024
@m-akinc m-akinc removed the triage New issue that needs to be reviewed label Jul 23, 2024
@jattasNI
Copy link
Contributor

The dev team has concerns with the 8px padding on the left edge being part of the breadcrumb (doesn't feel consistent with other components). Our proposal would be to keep it at 0px, ask Brandon to update the design to match that, and then update the place in SLE that uses the breadcrumb to have a 28px margin (or whatever total gap Brandon recommends).

Suggestion is to wait for Brandon to be back from OOO to confirm this direction or let him convince us why the designed layout is preferable.

@fredvisser fredvisser added the visual design Visual design work item label Jul 30, 2024
@fredvisser
Copy link
Contributor Author

Closing in favor of AzDO 2822271 to fix the breadcrumb spacing - Brandon may or may not make the Figma change, but it's unlikely to be an issue in the future either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working visual design Visual design work item
Projects
Status: Defined/Ready to Pickup
Development

No branches or pull requests

3 participants