Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This plugin seems to have screwed up my editor font size settings. #39

Closed
geekymon2 opened this issue Jul 21, 2021 · 5 comments
Closed
Labels
❓ Question A question to be answered

Comments

@geekymon2
Copy link

Tell us what you need help with.
Steps to replicate.

  1. Install the sliders plugin.
  2. enable the plugin by doing ctrl+shift+p
  3. uninstall the plugin

Now the enlarged font size is still enabled and i cannot get it back to normal. When i reinstall again and enable it, it goes even bigger. HELP.......... :(

@geekymon2 geekymon2 added the ❓ Question A question to be answered label Jul 21, 2021
@geekymon2
Copy link
Author

Nothing seems to be affecting the font size, where is this setting stored? i have removed the Code config, removed the usersettings everything it doesn't go back to normal even tried reinstalling vscode flatpak and seems to be affecting that as well.

@nicoespeon
Copy link
Owner

Hey @geekymon2 👋

Sorry for the inconvenience. The extension changes VSCode settings on the project where it's activated, then restore the original settings when deactivated.

If you're stuck with the "presentation mode" settings, you can restore it manually. The configuration is stored in a .vscode/settings.json, under the project root folder where it was activated. If you delete this file, you'll get your default settings back.

Re-installing VS Code won't change anything since it will continue to pick up the .vscode/settings.json file that's present in the project.

Can you check if it's here, delete it and let me know if that worked?

@geekymon2
Copy link
Author

geekymon2 commented Jul 21, 2021

Thanks, yeah I figured this out later yesterday. And got it sorted. Should those settings be removed by the extension if the extension is uninstalled? Or alternatively wouldn't it be better to have them in the user settings rather then project settings?

I was struggling to find it initially because I was looking in user settings

@nicoespeon
Copy link
Owner

Or alternatively wouldn't it be better to have them in the user settings rather then project settings?

The advantage of doing it "per project" is that it would only impact the project that is being presented. Applying it at the user level would impact all projects, with could be undesired I think.

Should those settings be removed by the extension if the extension is uninstalled?

That would be a great thing indeed! I didn't think about the scenario of uninstalling the extension. I don't know if an extension can execute some code on uninstall, I'd check this out.

If it can't, I would add an explanation in the README (e.g. some "Known issue" section) to help those who would get into this.

@geekymon2
Copy link
Author

Great thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❓ Question A question to be answered
Projects
None yet
Development

No branches or pull requests

2 participants