Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move test blobs to a submodule? #732

Closed
njlr opened this issue Sep 8, 2017 · 1 comment
Closed

Move test blobs to a submodule? #732

njlr opened this issue Sep 8, 2017 · 1 comment
Assignees
@nlohmann
Labels
release item: 🔨 further change solution: duplicate the issue is a duplicate; refer to the linked issue instead solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Milestone
Release 3.8.0

Comments

@njlr
Copy link
Contributor

njlr commented Sep 8, 2017

I am using the Buckaroo package for nlohmann/json and find it takes quite a long time to download. Looking at the repo, the test blobs seem to be the cause. Of course, these are not required when using the library.

Perhaps the tests should be moved to a Git submodule, so that they can be fetched optionally?
@nlohmann
Copy link
Owner

nlohmann commented Sep 8, 2017

Duplicate: #482 #96 #620.

@nlohmann nlohmann closed this as completed Sep 8, 2017
@nlohmann nlohmann added the solution: duplicate the issue is a duplicate; refer to the linked issue instead label Sep 8, 2017
@nlohmann nlohmann reopened this May 4, 2020
@nlohmann nlohmann mentioned this issue May 4, 2020
Merged
@nlohmann nlohmann self-assigned this May 4, 2020
@nlohmann nlohmann added release item: 🔨 further change solution: proposed fix a fix for the issue has been proposed and waits for confirmation labels May 4, 2020
@nlohmann nlohmann added this to the Release 3.8.0 milestone May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nlohmann nlohmann

Labels
release item: 🔨 further change solution: duplicate the issue is a duplicate; refer to the linked issue instead solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Projects
None yet
Milestone
Release 3.8.0
Development

No branches or pull requests
2 participants
@nlohmann @njlr