Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remapMethod from configure_nems.json not written to nems.configure #114

Open
ghost opened this issue Aug 4, 2021 · 2 comments
Open

remapMethod from configure_nems.json not written to nems.configure #114

ghost opened this issue Aug 4, 2021 · 2 comments
Labels
bug Bug when generating configuration

Comments

@ghost
Copy link

ghost commented Aug 4, 2021

for instance, when specifying :remapMethod=bilinear in configure_nems.json, the resulting nems.configure will have :remapMethod=redist instead

@ghost ghost added the bug Bug when generating configuration label Aug 4, 2021
@ghost ghost self-assigned this Aug 4, 2021
@ghost
Copy link
Author

ghost commented Aug 5, 2021

when only adding the method in the sequence list, it does not apply:

{
  "executable_path": "../../../../repositories/CoastalApp_PaHM/ALLBIN_INSTALL/NEMS.x",
  "modeled_start_time": "2018-08-30 06:00:00",
  "modeled_end_time": "2018-09-13 18:00:00",
  "interval": 3600.0,
  "connections": ["ATM -> OCN"],
  "mediations": [],
  "sequence": [
    "ATM -> OCN   :remapMethod=nearest_stod",
    "ATM",
    "OCN"
  ]
}

however, it DOES apply when adding the method to the connections list:

{
  "executable_path": "../../../../repositories/CoastalApp_PaHM/ALLBIN_INSTALL/NEMS.x",
  "modeled_start_time": "2018-08-30 06:00:00",
  "modeled_end_time": "2018-09-13 18:00:00",
  "interval": 3600.0,
  "connections": ["ATM -> OCN   :remapMethod=nearest_stod"],
  "mediations": [],
  "sequence": [
    "ATM -> OCN",
    "ATM",
    "OCN"
  ]
}

@ghost
Copy link
Author

ghost commented Aug 5, 2021

the fix should be to add methods if they are specified in the sequence list in the JSON

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug when generating configuration
Projects
None yet
Development

No branches or pull requests

0 participants