Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: De-tangle v-instructions directive completely #33

Open
1 of 4 tasks
toshify opened this issue Sep 14, 2020 · 1 comment
Open
1 of 4 tasks

refactor: De-tangle v-instructions directive completely #33

toshify opened this issue Sep 14, 2020 · 1 comment

Comments

@toshify
Copy link
Collaborator

toshify commented Sep 14, 2020

The v-instructions directive plugin is too entangled to the rest of the app. The litmus test is that it could not be provided as a npm package at this point. What needs to be done is:

  • (PR#31) allow configuration of overlay style when setting up plugin
  • allow overriding overlay style when using directive (v-instruction={audiourl, color})
  • allow configuring instruction vuex state name, so that a dev can configure what vuex state name to use for toggling instructions mode
  • have the plugin append the overlay rather than add it manually to
  • make use of vuetify configurable and optional [We're no longer using Vuetify, we've switched to Ionic]
@toshify toshify added front end dependencies Pull requests that update a dependency file A.2 labels Oct 16, 2020
@toshify toshify changed the title v-instructions directive is fully detangled Dev fully detangles v-instructions directive Oct 16, 2020
@toshify toshify changed the title Dev fully detangles v-instructions directive refactor: Dev fully detangles v-instructions directive May 21, 2021
@toshify toshify changed the title refactor: Dev fully detangles v-instructions directive refactor: Dev re-uses fully detangled v-instructions directive May 21, 2021
@toshify toshify removed the A.2 label Jun 27, 2021
@toshify toshify changed the title refactor: Dev re-uses fully detangled v-instructions directive refactor: Detangle v-instructions directive completely Sep 7, 2021
@toshify toshify changed the title refactor: Detangle v-instructions directive completely refactor: De-tangle v-instructions directive completely Sep 7, 2021
@toshify
Copy link
Collaborator Author

toshify commented Oct 12, 2023

Some work was done in relation to this in #388, but the instructions directive is still not fully detangled.

@toshify toshify removed the dependencies Pull requests that update a dependency file label Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant