Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken search for the mdi-norm package #26

Open
eugeneilyin opened this issue Feb 6, 2019 · 7 comments
Open

Broken search for the mdi-norm package #26

eugeneilyin opened this issue Feb 6, 2019 · 7 comments

Comments

@eugeneilyin
Copy link

eugeneilyin commented Feb 6, 2019

Hi, I have an issue with mdi-norm package.
The actual published package version is 2.0.0 with all fields filled, but the search index seems totally broken and frozen on some strange prehistoric state for this package.

No search is available for it within the console:

The npm search mdi-norm returns:

NAME      | DESCRIPTION          | AUTHOR          | DATE        | VERSION  | KEYWORDS
mdi-norm  |                      |                 | prehistoric | 0.0.0    |

And no search is available for it on npmjs.com:

image

Perhaps the below would also be useful information, to give an indication of the duration of broken search issue, and show that the displayed version in search does not exist at all.

The npm view mdi-norm time returns:

{ created: '2018-11-10T07:17:44.999Z',
'1.0.0': '2018-11-10T07:17:45.308Z',
modified: '2019-01-31T05:09:18.621Z',
'1.0.1': '2018-11-10T07:21:47.900Z',
'2.0.0': '2019-01-31T05:09:15.983Z' }

So the issue exists for 2 months as minimum.

P.S. The npmjs team told me that I should create an issue here in this repository to recover search index on npmjs.com site.

@eugeneilyin eugeneilyin changed the title Issue with Issue with 'mdi-norm' package Feb 6, 2019
@eugeneilyin eugeneilyin changed the title Issue with 'mdi-norm' package Issue with mdi-norm package Feb 6, 2019
@eugeneilyin eugeneilyin mentioned this issue Feb 6, 2019
@eugeneilyin eugeneilyin changed the title Issue with mdi-norm package Broken search for the mdi-norm package Feb 6, 2019
@eugeneilyin eugeneilyin changed the title Broken search for the mdi-norm package Broken search for the mdi-norm package Feb 6, 2019
@eugeneilyin
Copy link
Author

@satazor can you help here with elasticsearch indexes reset for the mdi-norm package, please?

@satazor
Copy link
Member

satazor commented Feb 13, 2019

@eugeneilyin it seems that mid-norm has too many files, you may see the error here:
https://api.npms.io/v2/package/mdi-norm

This is s protection against crafted tarballs that have many files and cause the machine to slow down when uncompromising.

@eugeneilyin
Copy link
Author

@satazor, I see the same issues for the same icons packages but for another icon libraries.
So what the next steps to increase file count limit for tarball processing?
Should I update code somewhere in npm search indexing to skip files analysis if the count exceed some limit?

@satazor
Copy link
Member

satazor commented Feb 14, 2019

The current limit is 32000 files which is quite generous.

Does the package has more than 32k files count?

@eugeneilyin
Copy link
Author

@satazor, no, the mdi-norm library has 25,075 files in 5 folders (the largest folders are es and lib contains 12,535 files). So the total limit of 32,000 files is not reached.

@eugeneilyin
Copy link
Author

@satazor, can I help somehow you with code verification, or checking max files per folder, or fixing some archive unpack logic to get the mdi-norm package parsing and indexing done?

@satazor
Copy link
Member

satazor commented Feb 22, 2019

Hi @eugeneilyin! Yes, you can see why the validation is triggering an error while the limit is not reached.

To do so, you may setup the analyser by following the instructions in the setup guide and by running the tasks process-package <name> CLI command to debug. This will require you to dig into the download and untar logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants