Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Salt only uses first 43 characters #51

Closed
coofercat opened this issue Sep 11, 2020 · 1 comment
Closed

Salt only uses first 43 characters #51

coofercat opened this issue Sep 11, 2020 · 1 comment

Comments

@coofercat
Copy link

This appears to be an issue upstream (which I raised there: davidaurelio/hashids-python#43), but may be worth knowing (and maybe documenting) here too. Advice such as:

HASHID_FIELD_SALT = "a long and secure salt value that is not the same as SECRET_KEY"

...isn't strictly true. Only the first 43 characters of whatever salt you supply are actually used. It remains to be seen if this is a bug, or undocumented feature (or me misunderstanding), but may save someone some time if they're trying things like salt=settings.HASHID_FIELD_SALT + 'something_else' in an attempt to have multiple salts in their application.

@nshafer
Copy link
Owner

nshafer commented Sep 11, 2020

Thanks for letting me know. I'll keep an eye on upstream, and perhaps add a note about it for now in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment