Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Verification and Attendance data from the BotGuild object to the Verification utility class. #225

Open
JPGarCar opened this issue Jul 14, 2021 · 1 comment
Labels
code-improvement enhancement New feature or request new feature A new feature to be added P2 (Priority 2) Medium priority for dev team.

Comments

@JPGarCar
Copy link
Contributor

Is your feature request related to a problem? Please describe.
A big problem with BotGuild is that it holds a lot of data and it is hard to keep track.
Furthermore, we have a Verification utility class that holds no data and is only used for the static functions that hold verification logic.

Describe the solution you'd like
My thought was we could port the BotGuild verification data to the Verification class.
Then this class will have its own toJson constructor and toJson function.
The BotGuild class will then contain a Verification object that uses its fromJson and toJson functions to build from and break into MongoDB data.

Describe alternatives you've considered
Just not doing it? HAHAH

Additional context
I think this is good to do because it will simplify the BotGuild object, reducing the amount of stuff it has, and also will take us down a path where we try to make sure our classes follow the Single Responsibility Principle.

@JPGarCar JPGarCar added enhancement New feature or request new feature A new feature to be added code-improvement P2 (Priority 2) Medium priority for dev team. labels Jul 14, 2021
@JPGarCar
Copy link
Contributor Author

If we are going down this road, it would be good to do the same with the StampManager class. Move all the stamp data from the BotGuilld class to the StampManager class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-improvement enhancement New feature or request new feature A new feature to be added P2 (Priority 2) Medium priority for dev team.
Projects
None yet
Development

No branches or pull requests

1 participant