Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"View all versions" toggle on search results page -- add labels #136

Open
lhenze opened this issue Nov 23, 2021 · 1 comment
Open

"View all versions" toggle on search results page -- add labels #136

lhenze opened this issue Nov 23, 2021 · 1 comment
Labels
a11y - significant Accessibility issues -- Must be fixed

Comments

@lhenze
Copy link
Member

lhenze commented Nov 23, 2021

From NYU A11y Review -

Toggle switch doesn't have a label.

The toggle switch (checkbox) to turn on/off "All Versions" does not have a for/id association with the label/input.

Consider:

<div class="ui toggle checkbox">
   <input class="hidden" readonly="" tabindex="0" type="checkbox" value="" name="toggle" id="toggle">
   <label for="toggle">View all versions</label>
</div>
@lhenze lhenze added the a11y - significant Accessibility issues -- Must be fixed label Nov 23, 2021
@lhenze
Copy link
Member Author

lhenze commented Dec 7, 2021

Created PR: inveniosoftware/invenio-app-rdm#1141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y - significant Accessibility issues -- Must be fixed
Projects
None yet
Development

No branches or pull requests

1 participant