Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Metrics cfg option naming typo #1168

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Fix Metrics cfg option naming typo #1168

merged 1 commit into from
Apr 27, 2021

Conversation

NickMeves
Copy link
Member

@NickMeves NickMeves commented Apr 23, 2021

#1163

How Has This Been Tested?

Unit Tests & contrib/local-environment manual testing

Checklist:

  • My change requires a change to the documentation or CHANGELOG.
  • I have updated the documentation/CHANGELOG accordingly.
  • I have created a feature (non-master) branch for my PR.

@NickMeves NickMeves requested a review from a team as a code owner April 23, 2021 20:23
Copy link
Member

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you had a chance to manually test this?

We should make sure we have a test in place that checks for duplicates in the flag and cfg options 🤔

@NickMeves
Copy link
Member Author

I think I should do more manual testing. I only spun one up with our contrib area with a metrics port enabled to recreate the reporter's original bug (I couldn't - they must have other flags intermixed giving that scenario where it is complaining about not starting up an HTTP non-secure metrics endpoint).

I'll find some time to get some local certs in place to test the secure version with this fix.

@NickMeves NickMeves merged commit d6de11a into master Apr 27, 2021
@NickMeves NickMeves deleted the metrics-tls-flag-fix branch April 27, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants