Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed .CustomLogin </form> tag placement for login page #1317

Merged
merged 2 commits into from
Aug 11, 2021
Merged

Fixed .CustomLogin </form> tag placement for login page #1317

merged 2 commits into from
Aug 11, 2021

Conversation

jord1e
Copy link
Contributor

@jord1e jord1e commented Aug 11, 2021 •
edited

Description

The template {{ end }} tag was in the wrong place, causing an extra closing </form> tag:

Showcase of the extra closing form tag

Motivation and Context

I found it a minor annoyance 😋.

How Has This Been Tested?

I ran the HTML through the W3C Markup Validation Service.

Checklist:

  • My change requires a change to the documentation or CHANGELOG.
  • I have updated the documentation/CHANGELOG accordingly.
  • I have created a feature (non-master) branch for my PR.

@jord1e jord1e requested a review from a team as a code owner August 11, 2021 12:57
@JoelSpeed
Copy link
Member

Good catch, please add a changelog entry and I'm happy to merge this

@JoelSpeed JoelSpeed added the bug label Aug 11, 2021
@jord1e
Copy link
Contributor Author

jord1e commented Aug 11, 2021

Done, thank you for maintaining this project.

JoelSpeed
JoelSpeed approved these changes Aug 11, 2021
View reviewed changes
Copy link
Member

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! LGTM

@JoelSpeed JoelSpeed merged commit 42c16ef into oauth2-proxy:master Aug 11, 2021
goshlanguage pushed a commit to goshlanguage/oauth2-proxy that referenced this pull request Sep 20, 2021
@jord1e @goshlanguage
Fixed .CustomLogin </form> tag placement for login page (oauth2-proxy…
7f50729 
…#1317)

* Fixed .CustomLogin </form> tag placement for login page

* Update changelog (oauth2-proxygh-1317)
k-jell pushed a commit to liquidinvestigations/oauth2-proxy that referenced this pull request Apr 6, 2022
@jord1e @k-jell
Fixed .CustomLogin </form> tag placement for login page (oauth2-proxy…
8aa1678 
…#1317)

* Fixed .CustomLogin </form> tag placement for login page

* Update changelog (oauth2-proxygh-1317)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed JoelSpeed approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jord1e @JoelSpeed