Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure claim extractor does not attempt profile call when URL is empty #1563

Merged
merged 2 commits into from
Feb 19, 2022

Conversation

JoelSpeed
Copy link
Member

@JoelSpeed JoelSpeed commented Feb 18, 2022

Description

This ensures that we don't attempt to make a profileURL call when the profileURL is empty.

Motivation and Context

Without this, the proxy logs an error when creating a session:

[2022/02/17 20:39:10] [oauthproxy.go:777] Error redeeming code during OAuth2 callback: could not get claim "groups": failed to fetch claims from profile URL: error making request to profile URL: error performing request: Get "": unsupported protocol scheme ""

CC @braunsonm as I know you found this while working on your PKCE PR

How Has This Been Tested?

Using the local testing environment, I could reproduce the issue until this fix was applied.

Checklist:

  • My change requires a change to the documentation or CHANGELOG.
  • I have updated the documentation/CHANGELOG accordingly.
  • I have created a feature (non-master) branch for my PR.

braunsonm
braunsonm previously approved these changes Feb 19, 2022
Copy link
Collaborator

@braunsonm braunsonm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JoelSpeed
Copy link
Member Author

Rebased to fix changelog conflicts, no other changes, will merge once the tests pass

@JoelSpeed JoelSpeed merged commit 1578d90 into master Feb 19, 2022
@JoelSpeed JoelSpeed deleted the fix-profile-url branch February 19, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants