Fill empty UserIDClaim before assigning it to other values #1920
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the email claim gets overridden if userIDClaim is not set.
Description
During login I am getting the error:
Motivation and Context
It seems to be related to:
#1623
#1732
The underlying problem seems to be the code that handles
Backwards Compatibility for Deprecated UserIDClaim option
. it overrides the EmailClaim if they are different. But at that point the UserIDClaim is still empty, if not explicitly set and so it clears EmailClaim. Later in the code it actually is explicitly set, so I just pulled this piece of code up.As this seems to be a workaround I am unsure about the behavior it should have and potential additional side-effects.
How Has This Been Tested?
I wrote a new test-case.
Checklist: