Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encrypt and decrypt the email and user in the cookie #67

Closed
wants to merge 8 commits into from
Closed

Encrypt and decrypt the email and user in the cookie #67

wants to merge 8 commits into from

Conversation

costelmoraru
Copy link
Contributor

Description

This change does one thing:

  • if a cypher is provided, it encrypts also the email and user with the same logic and algorithm as the rest of the fields from the session state.

Motivation and Context

This is the PR for the issue #60 .
Don't expose any information part of the cookie, information that can be easily retrieved if not encrypted.

How Has This Been Tested?

All the test from session_state_test are passing.
Testing in our environments.

Checklist:

  • My change requires a change to the documentation or CHANGELOG.
  • I have updated the documentation/CHANGELOG accordingly.
  • I have created a feature (non-master) branch for my PR.

@costelmoraru costelmoraru requested a review from a team February 17, 2019 21:10
@JoelSpeed
Copy link
Member

You may want to hold on this as there will be massive conflicts with #63

@JoelSpeed
Copy link
Member

#63 Has now been merged, @costelmoraru do you think you could modify the PR to work with the new changes that are in master?

@costelmoraru
Copy link
Contributor Author

Hi @JoelSpeed , I had a very busy week, but sometime this week I'm make time to adapt the changes and modify the PR.

@costelmoraru costelmoraru deleted the session-state-email branch April 9, 2019 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants