Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Enable the script to work for PowerVC #159

Open
cs-zhang opened this issue May 24, 2021 · 2 comments
Open

[FEATURE] Enable the script to work for PowerVC #159

cs-zhang opened this issue May 24, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@cs-zhang
Copy link
Contributor

Current script only works for PowerVS, now we want it to support PowerVC too.

@cs-zhang cs-zhang added the enhancement New feature or request label May 24, 2021
@yussufsh
Copy link
Collaborator

I feel it is better to create a common script for both powervs and powervc.
We can start with moving the common functions to a script and source it in the main script via the version (tag). This common script can be sourced from both the script.

Lets start with moving the functions for now then we can decide on how we can reuse the common code.

@cs-zhang
Copy link
Contributor Author

That's what I am doing now, create a common script, source it form script for PowerVS and PowerVC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants