Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename chelonia/db to chelonia.db and lock chelonia domain #2162

Open
taoeffect opened this issue Jul 6, 2024 · 0 comments
Open

Rename chelonia/db to chelonia.db and lock chelonia domain #2162

taoeffect opened this issue Jul 6, 2024 · 0 comments
Assignees
Labels
App:Frontend Kind:Core Anything that changes or affects the fundamental core data structures & design of the application. Note:Security Priority:High

Comments

@taoeffect
Copy link
Member

Problem

The chelonia domain has access to various important state. It should not be possible to register a new selector in it after it is loaded.

Solution

  1. Lock the entire chelonia domain.
  2. Since chelonia/db/* selectors are intended to be overwritable after Chelonia is loaded, rename them to be under the chelonia.db domain.

Consider also loading data like CHELONIA_STATE using chelonia.db instead of gi.db.

@taoeffect taoeffect added App:Frontend Note:Security Priority:High Kind:Core Anything that changes or affects the fundamental core data structures & design of the application. labels Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App:Frontend Kind:Core Anything that changes or affects the fundamental core data structures & design of the application. Note:Security Priority:High
Projects
None yet
Development

No branches or pull requests

2 participants