Duplicated notifications are possibly created in Cypress

[Silver-IT]

Problem

In this Cypress test, we can see the two notifications are same.

Actually, it is not allowed to create duplicated notification and we do this by comparing its hash.

[keys.ADD_NOTIFICATION] (state, notification: Notification) {
  if (state.items.some(item => item.hash === notification.hash)) {
    // We cannot throw here, as this code might be called from within a contract side effect.
    return console.error('This notification is already in the store.')
  }
  state.items.push(notification)
  // Sort items in chronological order, newest items first.
  state.items.sort(compareOnTimestamp)
}

I guess the reason might be the duplicated notification is created before the Vuex module notifications is cloned from the IndexedDB after login.

Solution

Fix it.

[Silver-IT]

Or the reason could be the identityContractID which is inside the data could be different.

[Silver-IT]

Having investigated more in detail, I have noticed that those two notifications are different ones. Just difference in period.
In my test the difference in period is just like the following.

The first one:  "2024-07-19T06:58:48.784Z"
The second one: "2024-07-19T06:57:26.630Z"

Also, I have noticed that it's related to the force change of distributionDate which is updated by forceDistributionDate function inside cy.giForceDistributionDateToNow().

[Silver-IT]

So this means this is not a bug, and it's the picky situation which only happens in Cypress.

[Silver-IT]

However, I will link this issue to the PR #2227 since I have added code to check notifications count there.