okta_policy_rule_signon in 4.8.1 requires both risk_level and risc_level to be specified

[MichalMMac]

I am sorry for not following your issue template but to do so I would need to spend an extra hour or two on this bug report so this is as good as it gets.

This huge da00dbc commit (Merged in #1954) which is part of 4.8.1 release introduced attribute specification change to okta_policy_rule_signon in okta/resource_okta_policy_rule_sign_on.go file.

I think the intention is for risk_level attribute to replace risc_level. However I have not seen this in release notes so I wonder if this is an intended change.

Side effect of this change is that both risk_level and risc_level need to be specified for non-default value to apply. When only one of the attributes is specified, provider wants to change the desired value to the default one - "ANY"

Here are the examples ->

4.8.1 only risc_level specified

Resource definition:

resource "okta_policy_rule_signon" "users_high-risk" {
  ...
  risc_level         = "HIGH"
  ...
}

terraform plan output:

  ~ resource "okta_policy_rule_signon" "users_high-risk" {
      ~ risk_level          = "HIGH" -> "ANY"
    }
    
Warning: Argument is deprecated

  with okta_policy_rule_signon.users_high-risk,
  on policy_global_session.tf line 301, in resource "okta_policy_rule_signon" "users_high-risk":
 301:   risc_level         = "HIGH"

Attribute typo, switch to risk_level instead. Default: `ANY`

Result: I get deprecation warning + undesired attribute value change

4.8.1 only risk_level specified

Resource definition:

resource "okta_policy_rule_signon" "users_high-risk" {
  ...
  risk_level         = "HIGH"
  ...
}

terraform plan output:

  ~ resource "okta_policy_rule_signon" "users_high-risk" {
  ...
       ~ risc_level          = "HIGH" -> "ANY"
  ...
    }

Result: Undesired attribute value change

4.8.1 both risk_level and risc_level specified

Resource definition:

resource "okta_policy_rule_signon" "users_high-risk" {
  ...
  risk_level         = "HIGH"
  risc_level         = "HIGH"
  ...
}

terraform plan output:

Warning: Argument is deprecated

  with okta_policy_rule_signon.users_high-risk,
  on policy_global_session.tf line 302, in resource "okta_policy_rule_signon" "users_high-risk":
 302:   risc_level         = "HIGH"

Attribute typo, switch to risk_level instead. Default: `ANY`

Result: I get deprecation warning

Terraform Version

Provider version 4.8.1

Affected Resource(s)

• okta_policy_rule_signon

[duytiennguyen-okta]

OKTA internal reference https://oktainc.atlassian.net/browse/OKTA-722279