Skip to content
This repository has been archived by the owner on Nov 23, 2022. It is now read-only.

HTTP Request is undefined in WebSockets #66

Open
stewartmcgown opened this issue Apr 20, 2021 · 3 comments
Open

HTTP Request is undefined in WebSockets #66

stewartmcgown opened this issue Apr 20, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@stewartmcgown
Copy link

stewartmcgown commented Apr 20, 2021

image
This bit of code expects there to be an express request object always present on the context. For long lived websocket connections, this isn't always the case. We should be able to fall back to the Websocket's original connecting IP and handle the rate limiting that way.
image

@onur-ozkan
Copy link
Owner

thanks for letting me know, I will work on it soon. @stewartmcgown

@onur-ozkan onur-ozkan added the bug Something isn't working label Apr 20, 2021
@stewartmcgown
Copy link
Author

I'm not even sure if its possible to get access to the original request object at this point. If not, we may have to add an extra setup step for the websocket connection that stores the connecting IP somewhere

@smiley-uriux
Copy link

This is essentially the same error I hit when reporting #41

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants