Skip to content
This repository has been archived by the owner on Nov 23, 2022. It is now read-only.

Rename method name "getIpFromRequest" #88

Open
dlancer opened this issue Dec 21, 2021 · 0 comments
Open

Rename method name "getIpFromRequest" #88

dlancer opened this issue Dec 21, 2021 · 0 comments
Labels
good first issue Good for newcomers

Comments

@dlancer
Copy link

dlancer commented Dec 21, 2021

Would be nice to rename/deprecate method name 'getIpFromRequest' and add something like getKeyFromRequest, because custom guards may not use IP as key, so such method name a bit misleading.
@onur-ozkan onur-ozkan added the good first issue Good for newcomers label Dec 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dlancer @onur-ozkan