Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update use of Makie (v0.20.0) to avoid deprecations #600

Open
ConnectedSystems opened this issue Nov 22, 2023 · 2 comments
Open

Update use of Makie (v0.20.0) to avoid deprecations #600

ConnectedSystems opened this issue Nov 22, 2023 · 2 comments

Comments

@ConnectedSystems
Copy link
Collaborator

Makie v0.20.0 was released recently (see here)

This comes with a number of performance improvements and support for HiDPI screens, as well as a few deprecations.

I think we should be mostly okay, but one notable change is that resolution is now size:

# Instead of this:
tf = Figure(resolution=(1600, 600))

# Do this:
tf = Figure(size=(1600, 600))

FYI @Zapiano this means more seamless plotting between CairoMakie and other backends, especially on Mac (because of the improved HiDPI screen support).

WGLMakie gets some performance improvements too.

@Zapiano
Copy link
Collaborator

Zapiano commented Nov 27, 2023

@ConnectedSystems

  1. How do we "update" Makie's version since when it is only used inside an extension? Should we add Makie = 0.20.0 to the [compat] section of Project.toml?

  2. Apparently one of the packages we depend on (DimensionalData) depends on version Makie's version 0.19.0. Is that an impediment, since Makie is only used by an extension..? I tried adding Makie = 0.20.0 to the [compat] section of Project.toml, going to my sandbox and updateing, but I got a compatibility restriction error:

image

@ConnectedSystems
Copy link
Collaborator Author

Should we add Makie = 0.20.0 to the [compat] section of Project.toml?

Yes

Apparently one of the packages we depend on (DimensionalData) depends on version Makie's version 0.19.0. Is that an impediment, since Makie is only used by an extension..?

Also yes. It means we can't update until this package also makes changes to update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants