Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "surprising" readjustment of the number of slices used to perform RSA/outcome mapping #615

Closed
ConnectedSystems opened this issue Dec 2, 2023 · 1 comment · Fixed by #702
Assignees
Labels
bug Something isn't working

Comments

@ConnectedSystems
Copy link
Collaborator

ConnectedSystems commented Dec 2, 2023

The number of conditioning points / slices / bins to use in RSA and outcome mapping ($S$) get automatically (and silently) adjusted to the maximum number of categorical values found in the model spec.

is_cat = (foi_spec.ptype .== "categorical")
if any(is_cat)
S = _category_bins(S, foi_spec[is_cat, :])
end

This has implications both to expected runtime, and validity of the analysis (an increase to the number of conditioning points generally increases the required number of samples).

Instead, the number of slices should only be increased for categorical/integer factors, not for everything.

The result matrix should instead of adjusted with column labels indicating the bin/quantile/conditioning point/position.
Only the columns that are relevant for a given factor should be filled.

This has implications for how the visualisations handle the result matrix so changes to address this needs careful consideration of visualisation processes.

@ConnectedSystems ConnectedSystems added the bug Something isn't working label Dec 2, 2023
@Rosejoycrocker
Copy link
Collaborator

Would you like me to address this @ConnectedSystems ? This is due to my my fixes for categorical variables so sorry about this. Also it would be good to have this working for my sensitivity analysis of mcda thresholds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants