Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide what to do with Builders #10621

Closed
Tracked by #11005
mx-psi opened this issue Jul 16, 2024 · 1 comment · Fixed by #11019
Closed
Tracked by #11005

Decide what to do with Builders #10621

mx-psi opened this issue Jul 16, 2024 · 1 comment · Fixed by #11019

Comments

@mx-psi
Copy link
Member

mx-psi commented Jul 16, 2024

As mentioned on #10375 (review), a remaining point of discussion for separating Profiles from the rest of the stable API was to do with the Builder structs for all component types. There are two main approaches we can take here:

  1. Completely remove Builders from the public API and make them private within the service module
  2. Add a Config method to Builders that allows users to get the configuration of a component (to then build profiles by using this and the Factory method)

(1) implies a breaking change, so I am adding this to Collector v1.

@mx-psi
Copy link
Member Author

mx-psi commented Aug 22, 2024

Fixed, we are moving them to service in #10782, #10783, #10785, #10784 and #10781. Next step is removing the deprecated API

@mx-psi mx-psi linked a pull request Aug 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant