Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review metadata.yaml units for internal telemetry: cmd/mdatagen/testdata #10654

Closed
Tracked by #10556
codeboten opened this issue Jul 17, 2024 · 2 comments
Closed
Tracked by #10556

Review metadata.yaml units for internal telemetry: cmd/mdatagen/testdata #10654

codeboten opened this issue Jul 17, 2024 · 2 comments
Milestone
Self observability

Comments

@codeboten
Copy link
Contributor

No description provided.

@codeboten codeboten mentioned this issue Jul 17, 2024
Closed
7 tasks
@codeboten codeboten changed the title cmd/mdatagen/testdata Review metadata.yaml units for internal telemetry: cmd/mdatagen/testdata Jul 17, 2024
@codeboten codeboten added this to the Self observability milestone Jul 17, 2024
@crobert-1
Copy link
Member

The only generic "1" unit type is here. This is a test data file used to ensure that the proper error is returned when a metadata.yaml attribute does not have a type.

Since the metric is for testing and exists just as a filler value to test something unrelated, I think we can close this issue and leave the unit as-is.

@codeboten
Copy link
Contributor Author

@crobert-1 sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Collector: v1
Archived in project
Milestone
Self observability
Development

No branches or pull requests
2 participants
@codeboten @crobert-1