Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assuming image dimensions in ctlra_cairo.c #104

Open
Be-ing opened this issue Jul 20, 2020 · 1 comment
Open

assuming image dimensions in ctlra_cairo.c #104

Be-ing opened this issue Jul 20, 2020 · 1 comment

Comments

@Be-ing
Copy link

Be-ing commented Jul 20, 2020

for(int i = 0; i < (480 * 272); i += 64) {

Shouldn't this be using the width and height parameters of the function?

@harryhaaren
Copy link
Member

harryhaaren commented Jul 20, 2020

Yes. Screen support is WIP, and there are lots of assumptions in the code for NI hardware with specific pixel dimensions right now.

[Edit]
To be clearer - each device will require its own "to device format" pixel conversion function. Here there are a few options to play with Cairo contexts at various different RGB888, or RGBA8888 formats, and convert the results into the device-speicfic formats. This needs to be abstracted via a function-pointer to enable all devices. At that point it must also scale to other pixel resolutions etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants