Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update file structure to closer match GO standards #289

Merged
merged 5 commits into from
Jun 6, 2018

Conversation

redhatrises
Copy link
Collaborator

This restructuring moves files/folders to match what other go projects are doing as well as
layout suggested at https://github.com/golang-standards/project-layout

@codecov
Copy link

codecov bot commented Jun 5, 2018

Codecov Report

Merging #289 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #289   +/-   ##
=======================================
  Coverage   89.48%   89.48%           
=======================================
  Files          32       32           
  Lines        1027     1027           
=======================================
  Hits          919      919           
  Misses         88       88           
  Partials       20       20
Impacted Files Coverage Δ
pkg/lib/standards/standard.go 100% <ø> (ø)
pkg/lib/components/versions/3_1_0/component.go 100% <ø> (ø)
pkg/lib/common/references.go 100% <ø> (ø)
pkg/cli/docs/gitbook/gitbook.go 81.81% <ø> (ø)
pkg/cli/docs/gitbook/gitbookSummaries.go 90.47% <ø> (ø)
pkg/lib/opencontrol/parse.go 90.47% <ø> (ø)
pkg/cli/get/resources/downloader.go 100% <ø> (ø)
pkg/cli/docs/gitbook/gitbookCertification.go 95.18% <ø> (ø)
pkg/lib/opencontrol/versions/1.0.0/opencontrol.go 93.54% <ø> (ø)
pkg/lib/components/parse.go 100% <ø> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c56329...c0508fb. Read the comment docs.

@redhatrises
Copy link
Collaborator Author

Ignore codeclimate CI failure. These are pre-existing issues that need to be worked out in the future for legacy code.

@redhatrises redhatrises changed the title [WIP] Update file structure to closer match GO standards Update file structure to closer match GO standards Jun 5, 2018
@shawndwells
Copy link
Member

Reviewed the codeclimate changes -- they're all legacy refactoring. Thanks for updating the project structure!

@shawndwells shawndwells merged commit 3ef42d3 into opencontrol:master Jun 6, 2018
@redhatrises redhatrises deleted the go_standards branch June 6, 2018 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants