-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
goreleaser updates #304
goreleaser updates #304
Conversation
redhatrises
commented
Jun 18, 2018
- Update goreleaser
- Add usage template
- Allow Makefile and goreleaser to build version into releases
8734b01
to
2696b92
Compare
Codecov Report
@@ Coverage Diff @@
## master #304 +/- ##
=======================================
Coverage 79.25% 79.25%
=======================================
Files 38 38
Lines 1427 1427
=======================================
Hits 1131 1131
Misses 244 244
Partials 52 52 Continue to review full report at Codecov.
|
9ee04d1
to
ecbfdee
Compare
- Update goreleaser - Add usage template - Allow Makefile and goreleaser to build version into releases
ecbfdee
to
ce8b798
Compare
This should also fix #170 |
github: | ||
owner: opencontrol | ||
name: homebrew-oscalkit | ||
name: homebrew-compliance-masonry | ||
commit_author: | ||
name: OpenControl | ||
email: [email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this EMail exist?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shawndwells figured you would know more than I about that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not something that's being changed in the PR, so no reason to hold a merge, just caught my eye.
|
||
Flags: | ||
Options: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
given the usage
output, should this be renamed to command-options
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. It shouldn't.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bah
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean you're right.
default help
behavior vs help get
@@ -12,19 +12,24 @@ import ( | |||
|
|||
var usage = ` | |||
Usage: | |||
masonry [command] | |||
masonry [global-options] COMMAND [command-options] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where are the global-options
documented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shawndwells In the help/usage outputs for each of the commands. For example, masonry help diff