Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More goreleaser fixes #310

Merged
merged 2 commits into from
Jun 21, 2018
Merged

Conversation

redhatrises
Copy link
Collaborator

  • Fix homebrew installs
  • Search env $PATH in cause masonry executable cannot be found

@codecov
Copy link

codecov bot commented Jun 21, 2018

Codecov Report

Merging #310 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #310   +/-   ##
=======================================
  Coverage   79.09%   79.09%           
=======================================
  Files          38       38           
  Lines        1430     1430           
=======================================
  Hits         1131     1131           
  Misses        246      246           
  Partials       53       53

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e41d49e...33c0b1c. Read the comment docs.

- Fix homebrew installs
- Search `env $PATH` in cause masonry executable cannot be found
@shawndwells
Copy link
Member

still no dice

$ pwd
/Users/shawnwells/Documents/github/opencontrol/compliance-masonry

$ compliance-masonry help


@shawndwells
Copy link
Member

p.s. if you're feeling super ambitious,

$ make
date: illegal option -- -
usage: date [-jnRu] [-d dst] [-r seconds] [-t west] [-v[+|-]val[ymwdHMS]] ... 
            [-f fmt date | [[[mm]dd]HH]MM[[cc]yy][.ss]] [+format]

@shawndwells
Copy link
Member

if using go build things work appropriately:

$ go build cmd/compliance-masonry/compliance-masonry.go 

$ ll build/
total 17816
-rwxr-xr-x  1 shawnwells  staff  1560976 Jun 21 17:48 compliance-masonry
-rwxr-xr-x  1 shawnwells  staff  7556284 Jun 21 17:48 masonry

$ ./build/compliance-masonry 
Compliance Masonry is a command-line interface (CLI) that
allows users to construct certification documentation using
the OpenControl Schema

Usage:
  masonry [command]

Available Commands:
  diff        Compliance Diff Gap Analysis
  docs        Create compliance documentation
  export      Export to consolidated output
  get         Install compliance dependencies
  help        Help about any command

Flags:
  -h, --help      help for masonry
      --verbose   Run with verbosity
  -v, --version   Print the version

Use "masonry [command] --help" for more information about a command.

@shawndwells
Copy link
Member

with changes, all appears OK:

$ make
go build -gcflags="-N -l" -ldflags="-s -w -X github.com/opencontrol/compliance-masonry/version.Version=1.1.3 -X github.com/opencontrol/compliance-masonry/version.Commit=33c0b1c -X github.com/opencontrol/compliance-masonry/version.Date=2018-06-21T22:04:54+0000"\
		-o ./build/masonry \
		cmd/masonry/masonry.go
go build -gcflags="-N -l" -ldflags="-s -w -X github.com/opencontrol/compliance-masonry/version.Version=1.1.3 -X github.com/opencontrol/compliance-masonry/version.Commit=33c0b1c -X github.com/opencontrol/compliance-masonry/version.Date=2018-06-21T22:04:54+0000"\
                -o ./build/compliance-masonry \
                cmd/compliance-masonry/compliance-masonry.go

$ ./build/compliance-masonry 
Compliance Masonry is a command-line interface (CLI) that
allows users to construct certification documentation using
the OpenControl Schema

Usage:
  masonry [command]

Available Commands:
  diff        Compliance Diff Gap Analysis
  docs        Create compliance documentation
  export      Export to consolidated output
  get         Install compliance dependencies
  help        Help about any command

Flags:
  -h, --help      help for masonry
      --verbose   Run with verbosity
  -v, --version   Print the version

Use "masonry [command] --help" for more information about a command.

@shawndwells shawndwells merged commit 65026da into opencontrol:master Jun 21, 2018
@redhatrises redhatrises deleted the fix_brew_env_path branch June 21, 2018 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants