Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[credentials] Test Python 3.11 #2427

Closed
Tracked by #234
feanil opened this issue Mar 28, 2024 · 5 comments · Fixed by #2389
Closed
Tracked by #234

[credentials] Test Python 3.11 #2427

feanil opened this issue Mar 28, 2024 · 5 comments · Fixed by #2389
Labels
blocked by other work PR cannot be finished until other work is complete needs maintainer attention Issue or PR specifically needs the attention of the maintainer.

Comments

@feanil
Copy link
Contributor

feanil commented Mar 28, 2024

No description provided.

@feanil feanil transferred this issue from openedx/public-engineering Mar 28, 2024
@hurtstotouchfire hurtstotouchfire added the needs maintainer attention Issue or PR specifically needs the attention of the maintainer. label Mar 28, 2024
@justinhynes
Copy link
Contributor

justinhynes commented Mar 29, 2024

I noticed there was a branch in Credentials to add Python 3.11 and 3.12 support, but it doesn't look ready for consumption yet. The branch is still in draft status with a few conflicts. We will keep our eyes on this and run through some tests once it looks like the work is ready.

@DawoudSheraz
Copy link

DawoudSheraz commented Apr 1, 2024

FYI - Tutor-credentials Python 3.12 Dockerfile upgrade is blocked on this overhangio/tutor-credentials#34 (comment)

@feanil feanil linked a pull request Apr 8, 2024 that will close this issue
@deborahgu deborahgu added the blocked by other work PR cannot be finished until other work is complete label Apr 10, 2024
@feanil
Copy link
Contributor Author

feanil commented Apr 18, 2024

@DawoudSheraz why do you need to land the tutor change before landing the update in credentials master? Or is credentials already testing with python 3.12?

@DawoudSheraz
Copy link

@DawoudSheraz why do you need to land the tutor change before landing the update in credentials master? Or is credentials already testing with python 3.12?

We are blocked on credentials upgrade. We did the initial testing of tutor-credentials on Python 3.12 but it failed due to dependencies issues in credentails (see overhangio/tutor-credentials#34 (comment)).

@kdmccormick kdmccormick changed the title [credentials] Test Python 3.11 and 3.12 [credentials] Test Python 3.11 May 8, 2024
@kdmccormick
Copy link
Member

As Dawoud mentioned, it seems like 3.12 was blocked on a dependency conflict (didkit) in this repo, not a downstream Tutor issue.

I've updated the title to reflect that we only added 3.11 support. I recommend opening a new issue for 3.12 support, which we'll need in Sumac.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked by other work PR cannot be finished until other work is complete needs maintainer attention Issue or PR specifically needs the attention of the maintainer.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants