Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect comment for OffchainVoting->voteResult case #258

Open
jtrein opened this issue Apr 21, 2021 · 0 comments
Open

Incorrect comment for OffchainVoting->voteResult case #258

jtrein opened this issue Apr 21, 2021 · 0 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@jtrein
Copy link
Member

jtrein commented Apr 21, 2021

// if the vote has started but the voting period has not passed yet, it's in progress
if (block.timestamp < vote.gracePeriodStartingTime + gracePeriod) {
  return VotingState.GRACE_PERIOD;
}

The comment should read as something to do with the state being in GRACE_PERIOD

@jtrein jtrein added the documentation Improvements or additions to documentation label Apr 21, 2021
@fforbeck fforbeck added the good first issue Good for newcomers label Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants