Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control method for providers to specify/access only their provider_ids/devices #551

Closed
schnuerle opened this issue Jul 9, 2020 · 4 comments
Labels
Agency Specific to the Agency API discussion Feedback is requested on an ongoing basis security Impacts the security of data flow/access or authentication

Comments

@schnuerle
Copy link
Member

Is your feature request related to a problem? Please describe.

Define a data access and/or authentication control method within MDS to allow providers to specify and access things like provider_ids and vehicle_ids, but only for approved providers and vehicles.

Part of the solution may include requiring that providers and cities talk about what a provider is allowed to see, and define that cooperatively digitally, and use that definition to validate specific data exchange.

Describe the solution you'd like

A clear and concise description of what you want to happen.

Is this a breaking change

  • I'm not sure

Impacted Spec

For which spec is this feature being requested?

  • agency
  • policy
  • provider

Describe alternatives you've considered

Likely not to allow this sort of functionality at all.

Additional context

This came up in regards to PR #469 and was identified in this comment. Allowing a provider to add any provider_ids they have control over would be problematic.

Another place this comes up with is with Stops in Agency, where device_ids and provider_id can be specified. Should providers be allowed to see other provider's vehicle_ids, and if not how do you constrain this?

@schnuerle schnuerle added Agency Specific to the Agency API discussion Feedback is requested on an ongoing basis labels Jul 9, 2020
@schnuerle schnuerle added this to the 1.1.0 milestone Jul 9, 2020
@schnuerle schnuerle added the security Impacts the security of data flow/access or authentication label Jul 9, 2020
@schnuerle
Copy link
Member Author

@Retzoh Do you have any thought on how to address this, given that it was part of a previous proposal you had?

@Retzoh
Copy link
Contributor

Retzoh commented Oct 12, 2020

@schnuerle I am personally not convinced that extended access control methods should be part of the MDS APIs.

Specifying who is allowed to access which data is already done when signing the data sharing agreements between the involved parties.

Controlling who is allowed to access which data is up to the implementation: you might prefer to encode the rights in a stateless JWT token, do a lookup in a relational database, etc. depending on your architecture.

In my opinion, the only things MDS may be missing to allow PR #469 for example are:

  • perhaps an unauthorized error type.
  • perhaps some wording expliciting that any implementation should enforce that the servers behind any requests is allowed to read/write the data is is trying to (although I hope everyone already does).

@Karcass @avatarneil what do you think ?

@schnuerle
Copy link
Member Author

Does anyone else have thoughts on this? We need some discussion and decisions for the 1.1.0 release timeline.

@schnuerle schnuerle modified the milestones: 1.1.0, Future Nov 4, 2020
@schnuerle
Copy link
Member Author

Moving to Future for now unless someone makes a PR proposal this week.

@schnuerle schnuerle removed this from the Future milestone Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Agency Specific to the Agency API discussion Feedback is requested on an ongoing basis security Impacts the security of data flow/access or authentication
Projects
None yet
Development

No branches or pull requests

2 participants