Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trip metadata to Agency #722

Closed
marie-x opened this issue Nov 9, 2021 · 0 comments · Fixed by #796
Closed

Add trip metadata to Agency #722

marie-x opened this issue Nov 9, 2021 · 0 comments · Fixed by #796
Assignees
Labels
Agency Specific to the Agency API Unification Work to unify MDS APIs like Agency, Provider with push/pull and data models
Milestone

Comments

@marie-x
Copy link
Collaborator

marie-x commented Nov 9, 2021

Is your feature request related to a problem? Please describe.

Agency does not have access to trip metadata available in Provider, including trip_distance, standard_cost, actual_cost, and currency. Most of the other trip data fields such as start_time and end_time are available from the /event stream.

Describe the solution you'd like

One possibility is to add a /trips endpoint to Agency that is fully symmetrical with Provider's /trips. To remove redundant route data, telemetry would not be sent during trips. This might make MDS more palatable to those with privacy concerns about in-trip tracking.

Another is to add a /trips endpoint that has only the otherwise-unavailable metadata, and continue to use /telemetry to provide route data (define as all telemetry occurring between start_time and end_time).

A third is to add event-specific fields to the trip_end event, but this has significant drawbacks such as making events non-uniform, as well as putting tension on timely trip-end-event-reporting vs. accurate trip-metadata-reporting. The trip distance may need to be calculated in a data pipeline, for example.

Is this a breaking change

  • Depends on the solution chosen

Impacted Spec

For which spec is this feature being requested?

  • agency

Describe alternatives you've considered

One possibility is to just use Provider and Agency side-by-side, but that's not on the table for LADOT.

Additional context

Nothing at the moment.

@marie-x marie-x self-assigned this Nov 9, 2021
@schnuerle schnuerle added the Agency Specific to the Agency API label Nov 10, 2021
@schnuerle schnuerle added this to the 2.0.0 milestone Nov 10, 2021
@schnuerle schnuerle added the Unification Work to unify MDS APIs like Agency, Provider with push/pull and data models label May 19, 2022
@schnuerle schnuerle linked a pull request Jan 9, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Agency Specific to the Agency API Unification Work to unify MDS APIs like Agency, Provider with push/pull and data models
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants