Skip to content

Commit

Permalink
Revert to using the upstream default of 1y for signing
Browse files Browse the repository at this point in the history
We plan on using long durations for when auto-approve is off and short
durations (<1d) for when they are on. A month was too far from either
extreme.
  • Loading branch information
smarterclayton committed Apr 2, 2018
1 parent fd34875 commit a7bd9d6
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions pkg/cmd/server/start/start_kube_controller_manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,6 @@ func computeKubeControllerManagerArgs(kubeconfigFile, saPrivateKeyFile, saRootCA
if _, ok := cmdLineArgs["cluster-signing-key-file"]; !ok {
cmdLineArgs["cluster-signing-key-file"] = []string{""}
}
if _, ok := cmdLineArgs["experimental-cluster-signing-duration"]; !ok {
cmdLineArgs["experimental-cluster-signing-duration"] = []string{"720h"}
}
if _, ok := cmdLineArgs["leader-elect-retry-period"]; !ok {
cmdLineArgs["leader-elect-retry-period"] = []string{"3s"}
}
Expand Down

0 comments on commit a7bd9d6

Please sign in to comment.