Fix deployment config scale subresource #17517
Conversation
openshift-ci-robot
added
approved
|
code LGTM |
|
Will fix up generated bits |
|
|
||
| // UpdateScale takes the top resource name and the representation of a scale and updates it. Returns the server's representation of the scale, and an error, if there is any. | ||
| func (c *deploymentConfigs) UpdateScale(deploymentConfigName string, scale *v1beta1.Scale) (result *v1beta1.Scale, err error) { | ||
| // FIXME: make non-homogenous subresource GV client generation work |
There was a problem hiding this comment.
I'll sync with @sttts tomorrow and try to fix it in client generation. Unless you do it first.
|
regenerated files, removed apps.openshift.io/v1 Scale from etcd test whitelist (no longer exists) |
|
/retest |
1 similar comment
|
/retest |
|
Hmmm... template service broker should not be affected by this chanage |
liggitt
added
the
do-not-merge/hold
|
removed unused import |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
| var scaleCodec = kapi.Codecs.LegacyCodec(v1beta1.SchemeGroupVersion) | ||
|
|
||
| // UpdateScale takes the top resource name and the representation of a scale and updates it. Returns the server's representation of the scale, and an error, if there is any. | ||
| func (c *deploymentConfigs) UpdateScale(deploymentConfigName string, scale *v1beta1.Scale) (result *v1beta1.Scale, err error) { |
There was a problem hiding this comment.
In 3.9, I'd rather have nothing than an untested, hand-written function in the external client. We can tell people to use the generic scale client.
For 3.7, I don't have a preference.
There was a problem hiding this comment.
In 3.9, I'd rather have nothing than an untested, hand-written function in the external client.
It's exercised by CI... in what way is it untested?
| var scaleCodec = kapi.Codecs.LegacyCodec(v1beta1.SchemeGroupVersion) | ||
|
|
||
| // UpdateScale takes the top resource name and the representation of a scale and updates it. Returns the server's representation of the scale, and an error, if there is any. | ||
| func (c *deploymentConfigs) UpdateScale(deploymentConfigName string, scale *v1beta1.Scale) (result *v1beta1.Scale, err error) { |
There was a problem hiding this comment.
Actually, is the client function ever used in 3.7? If not, let's just leave it deleted.
|
/retest |
|
/retest |
1 similar comment
|
/retest |
|
Thanks for the updates. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, liggitt The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
1 similar comment
|
/retest |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
@liggitt: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Automatic merge from submit-queue. |
3.6 and 3.7 shipped with the /apis/apps.openshift.io/deploymentconfigs/scale subresource returning apps.openshift.io/v1 Scale objects
This is a non-standard Scale object that the HPA will never be able to make use of.
The intent was to continue send the same thing as /oapi/v1/deploymentconfigs/scale: extensions/v1beta1 Scale objects
This PR fixes the groupified API to send/receive the correct type.
It also updates the UpdateScale() client method to send extensions/v1beta1 Scale objects