Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: 57211: Process cluster-scoped owners correctly #17820

Merged
merged 1 commit into from
Jan 5, 2018
Merged

UPSTREAM: 57211: Process cluster-scoped owners correctly #17820

merged 1 commit into from
Jan 5, 2018

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Dec 15, 2017

No description provided.

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 15, 2017
@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Dec 15, 2017
@liggitt liggitt added this to the 3.9.0 milestone Dec 15, 2017
@liggitt
Copy link
Contributor Author

liggitt commented Jan 3, 2018

/retest

@enj enj changed the title UPSTREAM: 57214: Process cluster-scoped owners correctly UPSTREAM: 57211: Process cluster-scoped owners correctly Jan 3, 2018
@enj
Copy link
Contributor

enj commented Jan 3, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enj, liggitt

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-ci-robot
Copy link

@liggitt: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_install 945fda7 link /test extended_conformance_install

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 17699, 17820).

@openshift-merge-robot openshift-merge-robot merged commit ee37719 into openshift:master Jan 5, 2018
@liggitt liggitt deleted the cluster-scoped-owners-3.9 branch January 5, 2018 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@marun marun Awaiting requested review from marun

Assignees

@enj enj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
v3.9
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@liggitt @enj @openshift-ci-robot @openshift-bot @openshift-merge-robot