Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stop special casing creation for ns lifecycle admission #17914

Merged
merged 2 commits into from
Jan 10, 2018
Merged

stop special casing creation for ns lifecycle admission #17914

merged 2 commits into from
Jan 10, 2018

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Dec 21, 2017

alternative to #17808

When running an openshift server, the admission plugin will always want to protect the openshift namespace. This simplifies the admission chain creation path. Only three left.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 21, 2017
@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Dec 21, 2017
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2017
@deads2k deads2k mentioned this pull request Dec 21, 2017
Closed
@deads2k
Copy link
Contributor Author

deads2k commented Dec 21, 2017

#17882

/retest

soltysh
soltysh approved these changes Jan 3, 2018
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, soltysh

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@deads2k
Copy link
Contributor Author

deads2k commented Jan 3, 2018

/retest

2 similar comments
@deads2k
Copy link
Contributor Author

deads2k commented Jan 4, 2018

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Jan 5, 2018

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Jan 5, 2018

/test all

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@soltysh
Copy link
Member

soltysh commented Jan 8, 2018

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@deads2k
Copy link
Contributor Author

deads2k commented Jan 10, 2018

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Jan 10, 2018

stuck?

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@deads2k
Copy link
Contributor Author

deads2k commented Jan 10, 2018

/retest

1 similar comment
@deads2k
Copy link
Contributor Author

deads2k commented Jan 10, 2018

/retest

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 17914, 18021, 18022, 17862, 18043).

@openshift-merge-robot openshift-merge-robot merged commit f39d224 into openshift:master Jan 10, 2018
@openshift-ci-robot
Copy link

@deads2k: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_install de77da5 link /test extended_conformance_install
ci/openshift-jenkins/extended_conformance_gce de77da5 link /test extended_conformance_gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k deads2k deleted the admission-03-lifecycle branch January 24, 2018 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@adelton adelton Awaiting requested review from adelton

@sttts sttts Awaiting requested review from sttts

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@deads2k @openshift-ci-robot @openshift-bot @soltysh @openshift-merge-robot