Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start-build: remove false alarm warning for repo binary input #20100

Conversation

wozniakjan
Copy link
Contributor

@wozniakjan wozniakjan commented Jun 26, 2018

I was able to create a zip archive that was as little as 183 bytes with valid but very short Dockerfile as the only file, so the peek was too large even for an archive created differently than from git repo and should probably not warn a false alarm

ptal @openshift/sig-developer-experience
including the conversation for reference #20090

also, I think the magic number for .gz was not completely correct, it had an extra byte (which is used to signal "deflate" compression algorithm but the byte can have different values as well and still denote .gz archive)
RFC for reference: https://tools.ietf.org/html/rfc1952

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 26, 2018
@wozniakjan wozniakjan force-pushed the startbuild/repo_archive_check branch from 4b7cc00 to def52d8 Compare June 26, 2018 15:11
@bparees
Copy link
Contributor

bparees commented Jun 26, 2018

/lgtm
/hold
(touches oc so needs to wait for the rebase)

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 26, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, wozniakjan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2018
@wozniakjan
Copy link
Contributor Author

/retest

@wozniakjan
Copy link
Contributor Author

/retest

flake #20101

@wozniakjan
Copy link
Contributor Author

wozniakjan commented Jun 28, 2018

/retest

extended_builds - Failed, no cause. Check <a href="https://github.com/openshift/origin/issues?q=is%3Aopen+is%3Aissue+label%3Akind%2Ftest-flake">the flake issues</a> and add a cause if necessary
extended_conformance_install -  FORWARD PARAMETERS TO THE REMOTE HOST
gcp - {"component":"entrypoint","level":"error","msg":"Process gracefully exited before 15s grace period","time":"2018-06-27T19:41:29Z"}

@bparees
Copy link
Contributor

bparees commented Jun 28, 2018

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 28, 2018
@bparees
Copy link
Contributor

bparees commented Jun 28, 2018

/refresh

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 0658af0 into openshift:master Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/cli lgtm Indicates that a PR is ready to be merged. sig/developer-experience size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants