Update egress IPs when node changes IP #20393
Conversation
danwinship
added
kind/bug
openshift-ci-robot
added
size/L
danwinship
force-pushed
the
egress-ip-node-renumbering
branch
from
a304769
to
b057704
Compare
|
/retest |
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
/retest |
|
/retest |
openshift-ci-robot
removed
the
do-not-merge/hold
|
@dcbw, @pravisankar see @bmeng 's question: https://bugzilla.redhat.com/show_bug.cgi?id=1607395#c2 Do you agree with my response? I'm pretty sure we need this... |
|
@danwinship I agree with your response. I know I have seen this in the past, though I admit I don't know how the situation was triggered. |
There was a problem hiding this comment.
/lgtm
@bmeng I concur with @danwinship's response on the bug.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, dcbw, pravisankar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Pointed out by @pravisankar while reviewing the fully-automatic egress IP stuff. This will probably need to be backported (which will probably involve backporting the
common/egressip.goPR too).(There is a similar bug with
NetNamespace.NetIDchanging, which will be addressed by a later PR.)Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1607395 (bug filed just to make sure we get QE tests)