Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: <drop>: increase loglevel for health check #20616

Merged
merged 1 commit into from
Aug 14, 2018
Merged

UPSTREAM: <drop>: increase loglevel for health check #20616

merged 1 commit into from
Aug 14, 2018

Conversation

mfojtik
Copy link
Contributor

@mfojtik mfojtik commented Aug 13, 2018 •
edited

@liggitt i don't see this in current upstream nor in 1.11 branch. Do we carry this in rebase ?

Fixes: http://bugzilla.redhat.com/show_bug.cgi?id=1608109

/cc @smarterclayton

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 13, 2018
@mfojtik
Copy link
Contributor Author

mfojtik commented Aug 13, 2018

/retest

@liggitt
Copy link
Contributor

liggitt commented Aug 13, 2018

/hold

the point of the health check is to detect hung output. to detect that, we need to do something that triggers glog.Flush(). https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver/pkg/server/healthz/healthz.go#L75-L89 would be a better way to do this.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 13, 2018
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 13, 2018
@mfojtik
Copy link
Contributor Author

mfojtik commented Aug 13, 2018

@liggitt fixed, thanks!

@liggitt
Copy link
Contributor

liggitt commented Aug 13, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2018
@liggitt
Copy link
Contributor

liggitt commented Aug 13, 2018

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 13, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, mfojtik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mfojtik
Copy link
Contributor Author

mfojtik commented Aug 13, 2018

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit f0d7e2d into openshift:master Aug 14, 2018
@mfojtik mfojtik deleted the upstream-healthz branch September 5, 2018 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@sttts sttts Awaiting requested review from sttts

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mfojtik @liggitt @openshift-ci-robot @openshift-bot @openshift-merge-robot