Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make cluster quota controller tolerate inaccessible api resources #20693

Merged

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Aug 20, 2018

@smarterclayton you were asking about this in the master channel

/assign @mfojtik
@juanvallejo since you expressed an interest

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 20, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2018
@deads2k
Copy link
Contributor Author

deads2k commented Aug 20, 2018

/retest

@smarterclayton
Copy link
Contributor

looks generally correct to me but I haven't looked at this in a while

@deads2k deads2k added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2018
@deads2k
Copy link
Contributor Author

deads2k commented Aug 21, 2018

lgtm'ed via slack

@openshift-merge-robot openshift-merge-robot merged commit a9901a5 into openshift:master Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants