oc debug: fix crash on attach

[rphillips]

o.AttachFunc is nil since we use our own custom oc debug command.
Attaching the defaultAttachFunc if nil fixes the crash and gives a
prompt.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1618522

[rphillips]

/test cmd

[sjenning]

Upstream pick that introduced this c7e00d1

oc debug calls directly into the AttachOptions.Run() and does not call Complete() which is what initializes o.AttachFunc to defaultAttachFunc in kubectl attach upstream. Thus upstream does not suffer this with kubectl attach but we do with oc debug.

LGTM but want CLI to look at this
/cc @sttts @juanvallejo

[rphillips]

We could improve the upstream code to avoid the carry patch by exporting the defaultAttachFunc. The initialization of AttachFunc is odd as well. By initializing the upstream AttachFunc in the New... constructors the code would be setup from the initial construction to be overridden by our debug implementation.

[rphillips]

Upstream PR: kubernetes/kubernetes#67615

[sjenning]

/hold
on different route proposed upstream

[juanvallejo]

lgtm provided upstream PR is approved

[juanvallejo]

Also, please split your commit into two. First one should be "UPSTREAM: 67615: attach: Move the AttachFunc default function to the initializer" and be up to date with upstream changes, second one should contain Origin changes

[soltysh]

Pick the upstream changes as a separate UPSTREAM commit and in the another one make the oc specific changes. I just approved uptream PR, so make sure to update that as well.

[rphillips]

@soltysh rebased and refactored... good to go for another review.

[rphillips]

/test cmd
/test integration

[soltysh]

/lgtm
/approve

[soltysh]

/hold cancel

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: rphillips, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/oc/OWNERS [soltysh]
• vendor/k8s.io/kubernetes/pkg/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[soltysh]

Upstream merged, this is properly updated, approving.

[openshift-ci-robot]

@rphillips: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/gcp	b051e60	link	/test gcp

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.