-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subsurfaces across thermal zones do not have outside boundary condition object assigned #561
Comments
Thanks for the report @manuvarkey. I believe that this issue is with the OpenStudio SDK, interior windows are not translated from FloorspaceJS to OSM with the correct Outside Boundary Condition Object property set. We could implement workarounds in the OS App but I think the best fix would be in the OS SDK, especially if there is work happening in this translation now. |
@macumber As per discussion on upstream bug report, this may not be an upstream issue. Further investigation may be required. |
I did some troubleshooting regarding this issue and found that Following code where a floorspace plan is loaded and translated produces
However the following code where a floorspace plan is loaded, translated and subsequently merged with a blank model produces
On going through the code in On going through the code for
However similar code is missing for setting In view of the above, it seems that the issue can be resolved by adding similar code to set @macumber since bug seems to be related to upstream, can you reopen the upstream bug report ? |
Wow, nice investigation @manuvarkey! I guess this is why @ggartside didn't find an issue with the floorspace reverse translator, the issue is in the ModelMerger. I'll file a new upstream issue to prevent confusion. |
Opened NREL/OpenStudio#5153 |
Issue overview
While geometry is created using inbuilt FloorspaceJS editor, subsurfaces (windows and doors) in walls across thermal zones do not have outside boundary condition object assigned in Spaces->Subsurfaces.
Current Behavior
No outside boundary condition objects are assigned in Spaces->Subsurfaces for internal windows and doors.
Following EnergyPlus error is thrown for all such subsurface.
Expected Behavior
Automatic assignment of Outside Boundary Condition Object should happen.
Steps to Reproduce
sample file.zip
Details
Environment
Some additional details about your environment for this issue (if relevant):
The text was updated successfully, but these errors were encountered: