Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal vs External IP in Axon #1965

Open
opendansor opened this issue May 31, 2024 · 1 comment · Fixed by #1984
Open

Internal vs External IP in Axon #1965

opendansor opened this issue May 31, 2024 · 1 comment · Fixed by #1984
Assignees
@opendansor

Comments

@opendansor
Copy link
Contributor

opendansor commented May 31, 2024 •
edited
Loading

Rename ip to internal_ip add a comment saying so.

On Axon.info return both internal_ip and external_ip (keep ip as it is, make a note for code-debt/deprecation later if needed)

This will help users clarify the difference in which ip they are looking at.

Add tests to verify functionality.
@opendansor opendansor self-assigned this May 31, 2024
@opendansor opendansor linked a pull request Jun 6, 2024 that will close this issue
Add e2e test for axon #1984
Merged
@thewhaleking
Copy link
Contributor

@opendansor is this issue resolved fully now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@opendansor opendansor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add e2e test for axon opentensor/bittensor
2 participants
@thewhaleking @opendansor