Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how the Bitrise file differs from what was committed #321

Closed
claudioandre-br opened this issue Apr 17, 2024 · 0 comments
Closed
Labels
documentation Improvements or additions to documentation

Comments

@claudioandre-br
Copy link
Member

1. Is your feature request related to a problem? Please describe

Bitrise validation conflicts with our linters. We must document how.

2. Describe the solution you'd like

I will add a patch file that shows where the differences are. It's just formatting.

diff --git a/deploy/Android-Delivery.yml b/deploy/Android-Delivery.yml
index 0427ab8..8021ea9 100644
--- a/deploy/Android-Delivery.yml
+++ b/deploy/Android-Delivery.yml
@@ -50,10 +50,10 @@ workflows:
 
   _deploy:
     steps:
-      - activate-ssh-key@4:
+    - activate-ssh-key@4:
         run_if: '{{getenv "SSH_RSA_PRIVATE_KEY" | ne ""}}'
-      - git-clone@8: {}
-      - [email protected]:
+    - git-clone@8: {}
+    - [email protected]:
         title: Checkout code
         inputs:
           - content: |-
@@ -63,7 +63,7 @@ workflows:
               rm -rf tmp
               git clone --depth 10 https://github.com/openwall/john.git tmp
               cp -r tmp/. .
-      - [email protected]:
+    - [email protected]:
         title: Building JtR
         inputs:
           - content: |-
@@ -85,7 +85,7 @@ workflows:
               mv README.md "${BITRISE_DEPLOY_DIR}/${default_apk_name}/"
               mv run "${BITRISE_DEPLOY_DIR}/${default_apk_name}/run"
               mv doc "${BITRISE_DEPLOY_DIR}/${default_apk_name}/doc"
-      - deploy-to-bitrise-io:
+    - deploy-to-bitrise-io:
         run_if: ".IsCI"
         inputs:
           - is_compress: "true"

IMO, this closed issue is enough to document. Closing.

@claudioandre-br claudioandre-br added the documentation Improvements or additions to documentation label Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant