Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dns queries with underscores are refused #585

Closed
scareything opened this issue Jan 11, 2023 · 0 comments · Fixed by #586
Closed

dns queries with underscores are refused #585

scareything opened this issue Jan 11, 2023 · 0 comments · Fixed by #586

Comments

@scareything
Copy link
Member

Validation in the DNS server prevents lookups for hostnames with '_' (and other non-alphanumeric chars) from being handled.

  1. Underscores are commonly used in SRV queries

  2. Section 11 of RFC 2181 clarifies that DNS servers should not refuse queries (or loading zones) due to characters in the labels.

    In particular, DNS servers must not refuse to serve a zone because it contains labels that might not be acceptable to some DNS client programs. A DNS server may be configurable to issue warnings when loading, or even to refuse to load, a primary zone containing labels that might be considered questionable, however this should not happen by default.

Based on this, we should remove the character validation in check_names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant