Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decorator for display errors #1513

Open
Abdel-Monaam-Aouini opened this issue Aug 31, 2022 · 5 comments
Open

Decorator for display errors #1513

Abdel-Monaam-Aouini opened this issue Aug 31, 2022 · 5 comments

Comments

@Abdel-Monaam-Aouini
Copy link

https://docs.oracle.com/en/database/oracle/oracle-database/18/drdas/error-code.html#GUID-3DB3995E-5FF8-4650-9216-A5B5C41CE2D7
image

@cjbj
Copy link
Member

cjbj commented Aug 31, 2022

Can you explain more about how you would this to be exposed? Would like to submit a PR with the suggestion?

@Abdel-Monaam-Aouini
Copy link
Author

Can you explain more about how you would this to be exposed? Would like to submit a PR with the suggestion?

when you have an error in your query, you don't know what's wrong, you waste a lot of time to know what's the error, these errors do not make sense,

@cjbj
Copy link
Member

cjbj commented Sep 1, 2022

@Monaam12 what exactly are you suggesting? The ORA errors are documented in https://docs.oracle.com/en/database/oracle/oracle-database/21/errmg/index.html However the ORA codes are not in the scope of this project since they are returned from the DB or Client libraries to node-oracledb and we can't change or control them directly. What do you want from node-oracledb? A mapping to SQLCODES? More doc? Or something else? I'm interested to know. Even if I can't make direct changes to other Oracle components I can always send feedback to the owners.

@cjbj
Copy link
Member

cjbj commented Sep 12, 2022

@Monaam12 can you clarify what you would like?

@Abdel-Monaam-Aouini
Copy link
Author

Abdel-Monaam-Aouini commented Sep 12, 2022

@Monaam12 can you clarify what you would like?

my point is about errors are not friendly for developers when you make something wrong!

I mean we can add something like this https://github.com/sequelize/sequelize/blob/main/src/errors/base-error.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants