Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display handlers should be able to output logs #1335

Open
qweeah opened this issue Apr 10, 2024 · 0 comments
Open

display handlers should be able to output logs #1335

qweeah opened this issue Apr 10, 2024 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@qweeah
Copy link
Contributor

qweeah commented Apr 10, 2024

Display handlers take care of formatting the output. It is possible that the output cannot be formatted, and handler need to output logs without terminating the whole execution.

E.g. when fetching a manifest, the content is successfully fetched but cannot be parsed into expected structure:

if err := json.Unmarshal(content, &manifest); err != nil {
manifest = nil
}

Currently such parsing errors are silently ignored.

@qweeah qweeah added triage New issues or PRs to be acknowledged by maintainers enhancement New feature or request labels Apr 10, 2024
@qweeah qweeah added this to the future milestone Apr 10, 2024
@qweeah qweeah removed the triage New issues or PRs to be acknowledged by maintainers label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant