Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

progress bar missing when copying artifact with zero-length layer from registry to OCI layout #1442

Open
1 task
qweeah opened this issue Jul 10, 2024 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@qweeah
Copy link
Contributor

qweeah commented Jul 10, 2024

What happened in your environment?

Tried to copy a self-made artifact with multiple zero-length layers from registry to local OCI image layout but see a progress bar missing in the terminal output

> oras cp --to-oci-layout jinzha1.azurecr.io/test:blank-progress .
✓ Copied  application/vnd.docker.container.image.v1+json                                                              0/0  B 100.00%    9ms
  └─ sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855
⠋ [....................](   0  B/s) Copying application/vnd.docker.image.rootfs.diff.tar.gzip                      0.00/0  B   0.00%   26ms
  └─ sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855
✓ Copied  application/vnd.docker.distribution.manifest.v2+json                                                  6.16/6.16 kB 100.00%   19ms
  └─ sha256:47506275bd97c02cd5f2c8c86d67d1faf8d3816ba0278aae63fb9cd25ec02e6c
Copied [registry] jinzha1.azurecr.io/test:blank-progress => [oci-layout] .
Digest: sha256:47506275bd97c02cd5f2c8c86d67d1faf8d3816ba0278aae63fb9cd25ec02e6c

What did you expect to happen?

Should show copied for the application/vnd.docker.image.rootfs.diff.tar.gzip layer

How can we reproduce it?

Run oras cp --to-oci-layout jinzha1.azurecr.io/test:blank-progress .

What is the version of your ORAS CLI?

Version: 1.2.0
Go version: go1.22.3
Git commit: dcef719
Git tree state: clean

What is your OS environment?

Window 11

Are you willing to submit PRs to fix it?

  • Yes, I am willing to fix it.
@qweeah qweeah added bug Something isn't working triage New issues or PRs to be acknowledged by maintainers labels Jul 10, 2024
@qweeah
Copy link
Contributor Author

qweeah commented Jul 10, 2024

Worth mentioning that this bug should exist in copy-specific code path, since mounting doesn't trigger this bug

> oras cp jinzha1.azurecr.io/sample-docker-image:from-sdk jinzha1.azurecr.io/bugs:blank-progress
✓ Mounted application/vnd.docker.image.rootfs.diff.tar.gzip                                                           0/0  B 100.00%     0s
  └─ sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855
✓ Mounted application/vnd.docker.container.image.v1+json                                                              0/0  B 100.00%     0s
  └─ sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855
✓ Copied  application/vnd.docker.distribution.manifest.v2+json                                                  6.16/6.16 kB 100.00%  856ms
  └─ sha256:47506275bd97c02cd5f2c8c86d67d1faf8d3816ba0278aae63fb9cd25ec02e6c
Copied [registry] jinzha1.azurecr.io/sample-docker-image:from-sdk => [registry] jinzha1.azurecr.io/bugs:blank-progress
Digest: sha256:47506275bd97c02cd5f2c8c86d67d1faf8d3816ba0278aae63fb9cd25ec02e6c

@qweeah qweeah removed the triage New issues or PRs to be acknowledged by maintainers label Jul 12, 2024
@qweeah qweeah added this to the v1.3.0 milestone Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant